Skip to content

test: add environment check for ERC1155 mintToBatch tests #5115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

test: add environment check for ERC1155 mintToBatch tests #5115

merged 1 commit into from
Oct 21, 2024
+57 −54

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 21, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR refactors the test for the mintToBatch function in the ERC1155 Edition module, enhancing its structure and clarity. It modifies the test to run conditionally based on the presence of a secret key and organizes the minting logic more effectively.

Detailed summary

  • Changed describe to run conditionally with process.env.TW_SECRET_KEY.
  • Improved organization of the test case for mintToBatch.
  • Added account to the contract deployment parameters.
  • Consolidated the minting transaction logic.
  • Retained the NFT expectation check after minting.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 11:14pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 11:14pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 11:14pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 11:14pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 40aeb52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 21, 2024 22:43
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 733 ms (+16.06% 🔺) 1.6 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 1.6 s (-9.83% 🔽) 3.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 168 ms (+316.28% 🔺) 265 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 52 ms (+231.5% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 336 ms (+166.04% 🔺) 684 ms

@codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (e7bbc32) to head (40aeb52).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5115   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54754    54754           
  Branches     3956     3959    +3     
=======================================
+ Hits        24802    24803    +1     
+ Misses      29261    29260    -1     
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e7bbc32
packages 40.24% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@joaquim-verges
test: add environment check for ERC1155 mintToBatch tests (#5115)
40aeb52 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR modifies the test for the `mintToBatch` function in the `ERC1155 Edition` to include conditional execution based on the presence of a `TW_SECRET_KEY`. It also refactors the test structure, improving readability and organization.

### Detailed summary
- Changed `describe` to conditionally run based on `process.env.TW_SECRET_KEY`.
- Refactored the test structure for `mintToBatch`.
- Moved the `sendAndConfirmTransaction` call inside the test.
- Added detailed NFT validation after minting.
- Removed redundant code and improved clarity.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the test_add_environment_check_for_ERC1155_mintToBatch_tests branch from 9af525b to 40aeb52 Compare October 21, 2024 23:00
@jnsdls Graphite App
Copy link
Member

jnsdls commented Oct 21, 2024

Merge activity

@graphite-app graphite-app bot merged commit 40aeb52 into main Oct 21, 2024
30 of 31 checks passed
@graphite-app graphite-app bot deleted the test_add_environment_check_for_ERC1155_mintToBatch_tests branch October 21, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

Assignees

No one assigned

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @jnsdls